sketch #1
Merged
sketch #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
commented
Aug 24, 2023
| from typing import Optional | ||
|
|
||
| import boto3 | ||
| import httpx |
There was a problem hiding this comment.
I've switched from requests to httpx
vincentsarago
commented
Aug 24, 2023
| error_wrappers, | ||
| validator, | ||
| ) | ||
| from stac_pydantic import Collection, Item, shared |
There was a problem hiding this comment.
I think we should drop the stac-pydantic requirement and use our own model.
stac-pydantic is unmaintained and it's not clear to me if it's going to be updated in the future
vincentsarago
commented
Aug 24, 2023
Fix type errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref developmentseed/eoapi-cdk#4