Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildfly 2.0.1 #311

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Wildfly 2.0.1 #311

merged 2 commits into from
Mar 13, 2024

Conversation

ehsavoie
Copy link
Collaborator

@ehsavoie ehsavoie commented Mar 4, 2024

What does this PR do?:

Upgrade WildFly stack

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

configuration options using variables

Signed-off-by: Emmanuel Hugonnet <[email protected]>
@ehsavoie
Copy link
Collaborator Author

ehsavoie commented Mar 5, 2024

I don't understand the odo failure as i couldn't reproduce locally

@ehsavoie
Copy link
Collaborator Author

ehsavoie commented Mar 5, 2024

/retest

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehsavoie added a suggestion which will fix the error:

Failed to delete inner loop resources: failed to gather resources for
deletion: yaml: line 39: could not find expected ':'

stacks/java-wildfly/2.0.1/deploy.yaml Outdated Show resolved Hide resolved
Signed-off-by: Emmanuel Hugonnet <[email protected]>
@thepetk thepetk self-requested a review March 8, 2024 14:28
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Mar 8, 2024
Copy link

openshift-ci bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehsavoie, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 8, 2024
@thepetk thepetk merged commit 8886f2b into devfile:main Mar 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants