Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add aggregate rating stats #3382

Merged
merged 2 commits into from
Feb 21, 2025
Merged

feature: add aggregate rating stats #3382

merged 2 commits into from
Feb 21, 2025

Conversation

densumesh
Copy link
Contributor

@densumesh densumesh commented Feb 16, 2025 •
edited
Loading

Please indicate what issue this PR is related to and @ any maintainers who are relevant

image

@densumesh densumesh force-pushed the ds/add-aggregate-rating-stats branch 2 times, most recently from 2d2403a to e4ce420 Compare February 16, 2025 01:44
@skeptrunedev skeptrunedev force-pushed the ds/add-aggregate-rating-stats branch from e4ce420 to e81f321 Compare February 16, 2025 06:01
skeptrunedev
skeptrunedev requested changes Feb 17, 2025
View reviewed changes
@skeptrunedev
Copy link
Contributor

image

image

It looks like something is broken for me locally on this. Maybe I need to run a migration?

@densumesh densumesh force-pushed the ds/add-aggregate-rating-stats branch from e81f321 to 7404aca Compare February 18, 2025 00:03
@densumesh
Copy link
Contributor Author

image
hmm its working for me and i remade my CH db so not sure

@skeptrunedev skeptrunedev force-pushed the ds/add-aggregate-rating-stats branch from 7404aca to 53d212c Compare February 18, 2025 00:15
@densumesh densumesh force-pushed the ds/add-aggregate-rating-stats branch from 53d212c to 5282de5 Compare February 18, 2025 00:47
@skeptrunedev skeptrunedev force-pushed the ds/add-aggregate-rating-stats branch from 5282de5 to 551b5ee Compare February 19, 2025 21:51
skeptrunedev
skeptrunedev requested changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@skeptrunedev skeptrunedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

skeptrunedev
skeptrunedev previously requested changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@skeptrunedev skeptrunedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

doesn't seem to work correctly, these numbers are wrong

@densumesh
Copy link
Contributor Author

image

the first one is for the search ratings and the second is rag ratings, they are distinct in CH

@densumesh
Copy link
Contributor Author

=

image

image

doesn't seem to work correctly, these numbers are wrong

you didnt add the dashboard screenshot but the percents are based off of % like/dislike over total chats/searches, should it be only the rated searches/chats?

@skeptrunedev
Copy link
Contributor

=

image
image
doesn't seem to work correctly, these numbers are wrong

you didnt add the dashboard screenshot but the percents are based off of % like/dislike over total chats/searches, should it be only the rated searches/chats?

No, doing it over the total is fine, but in this case the dislike shouldn't be 0. Something seems off there.

@cdxker cdxker merged commit aa70f4d into main Feb 21, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdxker cdxker cdxker approved these changes

@skeptrunedev skeptrunedev skeptrunedev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@densumesh @skeptrunedev @cdxker