chore: update dfx deploy output
#4104
Merged
+262
−156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericswanson-dfinity
requested changes
Feb 10, 2025
| "{} code for canister {}", | ||
| install_mode_to_prompt(&mode), | ||
| canister_id, | ||
| let spinner = env.new_spinner( |
There was a problem hiding this comment.
This doesn't play well with the "ask for consent" and interactive parameter prompting in that can happen when installing a canister. To repro, for example:
$ dfx canister install --wasm /Users/ericswanson/d/sdk/e2e/assets/wasm/identity/main.wasm --mode reinstall react_rust_backend
⠁ Reinstalling code for canister react_rust_backend, with canister ID bkyz2-fmaaa-aaaaa-qaaaq-cai WARNING!
You are about to reinstall the react_rust_backend canister
This will OVERWRITE all the data and code in the canister.
YOU WILL LOSE ALL DATA IN THE CANISTER.
Do you want to proceed? yes/No
⠋ Reinstalling code for canister react_rust_backend, with canister ID bkyz2-fmaaa-aaaaa-qaaaq-cai
| @@ -325,7 +329,7 @@ async fn install_canisters( | |||
| no_asset_upgrade: bool, | |||
| always_assist: bool, | |||
| ) -> DfxResult { | |||
| info!(env.get_logger(), "Installing canisters..."); | |||
| let spinner = env.new_spinner("Installing canisters...".into()); | |||
There was a problem hiding this comment.
This also conflicts with prompting about upgrades or for initialization arguments:
$ dfx deploy
...
⠂ Installing canisters...
⠁ Installing code for canister dd_backend, with canister ID br5f7-7uaaa-aaaaa-qaaca-cai
This canister requires an initialization argument.
Auto-completions: aaabbbccc, abc3, abc4, alice, alice_e2e, anonymous, bob, bob_e2e, dd_backend, dd_frontend, default, ed, iii, k3, kt2, kt4, mainnet,⠠ Installing canisters...
⠤ Installing code for canister dd_backend, with canister ID br5f7-7uaaa-aaaaa-qaaca-cai
ericswanson-dfinity
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK-1945