Mashrukh - DHedge Frontend Widget #2
Conversation
|
Please delete the React images that come by default with the React app template. If you need the dHEDGE logo, let me know. I can post it here |
|
@mushroomgenie this PR still contains React logos |
|
@edsonayllon removed from the public folder |
You can use these images to replace them |
src/components/Header/index.tsx
Outdated
| <button | ||
| className="bg-gradient-to-r from-blue bg-blue-light text-white text-shadow-blue font-semibold px-6 py-2 whitespace-nowrap rounded-full text-base tracking-wide" | ||
| onClick={openConnectModal} | ||
| > | ||
| {account ? address : "Connect Wallet"} | ||
| </button> |
There was a problem hiding this comment.
Ok, so, the widget shouldn't handle the wallet connection. The external app should handle connecting the wallet. You can see Uniswap's widget as a reference. It passes the provider and a JSON RPC endpoint as props to the widget. https://docs.uniswap.org/sdk/widgets/swap-widget
There was a problem hiding this comment.
@edsonayllon I made a commit regarding this, could you please check if it's right implementation ?
|
@mushroomgenie How was this tested? There's a connect wallet button in the app that doesn't do anything |
|
@mushroomgenie The frontend team looked at this PR. They reported the following:
We created this bounty as our capacity was focused on the previous release. Now with that release deployed, our frontend team can take this task on. It seems we underestimated the amount of effort this project requires when creating the bounty. We will be using a different approach to deal with this use case than an NPM package. Though, we want to give you a partial payout for your work and effort |
|
@edsonayllon I used the axios for graphql because I was calling another API endpoint(dehedge graphql API) for it and the urql is fetching from the optimism subgraph. |
No description provided.