feat: display notifications on transactions errors #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimlbc
force-pushed
the
feat/handle-transaction-errors
branch
from
20baccc to
44f0c1e
Compare
D-Ig
reviewed
Nov 19, 2024
There was a problem hiding this comment.
can have a single instance of
{
title: 'Low Slippage',
hint: 'Please increase slippage tolerance and try again.',
}
not to repeat changes once they are needed.
I think it's totally okay to show revert message for "unkown" errors (which haven't been found at TRANSACTION_ERRORS).
|
Added 
|
D-Ig
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/4atDqluw/4634-handle-swap-data-error
Added transaction error notifications with the ability to provide detailed explanations for specific errors
Unknown errors:
@D-Ig need your help in filling
TRANSACTION_ERRORSmapWe can also hide or adjust the message for unknown errors.