Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log all types of withdrawals as a single analytics event #151

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

@artsiomYavorski
Copy link
Contributor

@dimlbc looks good. What do you think of refactoring a bit a switch construction by:

  • all case blocks replace by Record<TransactionAction, Array<Event Name>> object map
  • use log method at bottom at single place by iterating event names array

@dimlbc dimlbc force-pushed the feat/aggregated-withdrawal-event branch from fe5078b to 1973949 Compare January 7, 2025 08:50
@dimlbc
Copy link
Member Author

dimlbc commented Jan 7, 2025

@dimlbc looks good. What do you think of refactoring a bit a switch construction by:

  • all case blocks replace by Record<TransactionAction, Array<Event Name>> object map
  • use log method at bottom at single place by iterating event names array

good idea, refactored

@dimlbc dimlbc merged commit 1c48a38 into main Jan 7, 2025
1 check passed
@dimlbc dimlbc deleted the feat/aggregated-withdrawal-event branch January 7, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants