Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ro.ttf font everywhere #148

Merged
merged 5 commits into from
Jun 28, 2017
Merged

use ro.ttf font everywhere #148

merged 5 commits into from
Jun 28, 2017

Conversation

jonathanraes
Copy link
Collaborator

Closes #142

wkmeijer
wkmeijer requested changes Jun 27, 2017
View reviewed changes
Copy link
Member

@wkmeijer wkmeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the fonts of the error messages in the passport connection activity.

wkmeijer
wkmeijer requested changes Jun 28, 2017
View reviewed changes
Copy link
Member

@wkmeijer wkmeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Turn on NFC" snackbar still has the old font. Furthermore the background of the toasts is now transparent, which makes it really hard to read in some activities.

@landgenoot landgenoot merged commit 5e0ce7f into develop Jun 28, 2017
@landgenoot landgenoot deleted the feature/142_use_ro_font branch June 28, 2017 22:09
@landgenoot landgenoot restored the feature/142_use_ro_font branch June 28, 2017 22:23
@landgenoot landgenoot mentioned this pull request Jun 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkmeijer wkmeijer wkmeijer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathanraes @wkmeijer @landgenoot