Update dependencies to rapier 0.21 #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vrixyz
commented
Jun 28, 2024
Comment on lines
+3
to
13
| ## Unreleased | ||
|
|
||
| **This is an update from rapier 0.19 to Rapier 0.21 which includes several stability improvements | ||
| and new features. Please have a look at the | ||
| [0.20 and 0.21 changelogs](https://github.com/dimforge/rapier/blob/master/CHANGELOG.md) of Rapier.** | ||
|
|
||
| - Update to rapier `0.21`. | ||
| - Update to nalgebra `0.33`. | ||
|
|
||
| ## v0.27.0-rc.1 (18 June 2024) | ||
|
|
There was a problem hiding this comment.
I think this should be merged into 1 as we havn't made a final release.
Mentionning both release candidates and final releases in changelog will only lead to misunderstandings
Vrixyz
commented
Jun 28, 2024
| @@ -454,7 +454,7 @@ impl RapierContext { | |||
| query_pipeline, | |||
| (&scaled_shape).into(), | |||
| shape_mass, | |||
| collisions.iter().copied(), | |||
| collisions.iter(), | |||
There was a problem hiding this comment.
an alternative is to pass &*collisions, to "reborrow" it immutably. I'm not sure if that needs a migration guide (it has to be compared with bevy_rapier 0.26, not master)
sebcrozet
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #535, #542, #541, #540