Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Wagtail-6 #49

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

vegaelle
Copy link
Contributor

This PR adds support for Wagtail >6.0, which removed wagtail.contrib.modeladmin, and recommends to use wagtail_modeladmin instead.

  • Tests still pass: poetry run pytest: ✔️
  • There are no lint errors: poetry run pre-commit run --all-files: ✔️

@vegaelle
Copy link
Contributor Author

In order to fix failures with old Wagtail versions, i’ll add tests to use either wagtail.contrib.modeladmin or wagtail_modeladmin

@vegaelle vegaelle force-pushed the wagtail6 branch 4 times, most recently from ee41727 to 0aaae70 Compare August 19, 2024 15:35
@dinoperovic
Copy link
Owner

Hi @vegaelle, thank you for the PR, sorry I did not see it before.

This looks good, will merge and create a new release. Also adding you to the credits ;)

My plan is however to migrate to using Wagtail snippets for order display in the CMS, as that is the new way to show custom pages in Wagtail. This was something I started to work on, but haven't yet got the time to implement fully.

This is a good transition though, thanks!

@dinoperovic dinoperovic merged commit 01ca483 into dinoperovic:master Sep 18, 2024
19 checks passed
@dinoperovic
Copy link
Owner

Version 1.2.1 was released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants