dev: Add docs&types&autocomplete for lodash import yay (fonsp#2135)

* Add types for lodash import yay

* Update TypeScriptCheck.yml

* type fixes thanksss

.github/workflows/TypeScriptCheck.yml

@@ -27,5 +27,8 @@ jobs:
 
       - run: npm install typescript -g
 
+      - run: npm install
+        working-directory: frontend
+
       - name: Run TypeScript checks on frontend/
         run: tsc --noEmit --strictNullChecks false

.gitignore

@@ -16,3 +16,4 @@ node_modules
 frontend/dist
 .net
 net
+frontend/package-lock.json

frontend/components/CellInput.js

@@ -729,7 +729,7 @@ export const CellInput = ({
         if (lines_wrapper_dom_node) {
             const lines_wrapper_resize_observer = new ResizeObserver(() => {
                 const line_nodes = lines_wrapper_dom_node.children
-                const tops = _.map(line_nodes, (c) => c.offsetTop)
+                const tops = _.map(line_nodes, (c) => /** @type{HTMLElement} */ (c).offsetTop)
                 const diffs = tops.slice(1).map((y, i) => y - tops[i])
                 const heights = [...diffs, 15]
                 on_line_heights(heights)

frontend/components/RecordingUI.js

@@ -300,19 +300,16 @@ export const RecordingPlaybackUI = ({ launch_params, initializing, apply_noteboo
 
         let new_timestamp = audio.currentTime
         let forward = new_timestamp >= current_state_timestamp_ref.current
-        /**
-         * @param {T} x @template T @return {T}
-         */
-        let directed = (x) => (forward ? x : _.reverse(x))
+        let directed = forward ? _.identity : _.reverse
 
         let lower = Math.min(current_state_timestamp_ref.current, new_timestamp)
         let upper = Math.max(current_state_timestamp_ref.current, new_timestamp)
 
         let scrolls_in_time_window = deserialized.scrolls.filter(([t, s]) => lower < t && t <= upper)
         if (scrolls_in_time_window.length > 0) {
-            let scroll_state = _.last(directed(scrolls_in_time_window))[1]
+            let scroll_state = _.last(directed(scrolls_in_time_window))?.[1]
 
-            on_scroll(scroll_state)
+            if (scroll_state) on_scroll(scroll_state)
         }
 
         let steps_in_current_direction = forward ? deserialized.steps : computed_reverse_patches_ref.current

frontend/imports/lodash.d.ts

@@ -0,0 +1,2 @@
+import _ from "lodash-es"
+export default _

frontend/package.json

@@ -0,0 +1,6 @@
+{
+  "devDependencies": {
+    "@types/lodash": "^4.14.182",
+    "@types/lodash-es": "^4.17.6"
+  }
+}