[Fix] ButtonBuilder validations(#2943)

discord-net · Jun 17, 2024 · 5a71ad3 · 5a71ad3
1 parent 9d92435
commit 5a71ad3
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/Discord.Net.Core/Entities/Interactions/MessageComponents/Builders/ButtonBuilder.cs b/src/Discord.Net.Core/Entities/Interactions/MessageComponents/Builders/ButtonBuilder.cs
@@ -267,9 +267,6 @@ public ButtonBuilder WithSkuId(ulong? skuId)
     /// <exception cref="InvalidOperationException">A non-link button must contain a custom id</exception>
     public ButtonComponent Build()
     {
-        if (string.IsNullOrWhiteSpace(Label) && Emote is null)
-            throw new InvalidOperationException("A button must have an Emote or a label!");
-
         var a = 0;
         if (!string.IsNullOrWhiteSpace(Url))
             a++;
@@ -293,6 +290,8 @@ public ButtonComponent Build()
             case ButtonStyle.Success:
             case ButtonStyle.Danger:
             {
+                if (string.IsNullOrWhiteSpace(Label) && Emote is null)
+                    throw new InvalidOperationException("A button must have an Emote or a label!");
                 if (string.IsNullOrWhiteSpace(CustomId))
                     throw new InvalidOperationException("Non-link and non-premium buttons must have a custom id associated with them");
 
@@ -301,6 +300,8 @@ public ButtonComponent Build()
 
             case ButtonStyle.Link:
             {
+                if (string.IsNullOrWhiteSpace(Label) && Emote is null)
+                    throw new InvalidOperationException("A button must have an Emote or a label!");
                 if (string.IsNullOrWhiteSpace(Url))
                     throw new InvalidOperationException("Link buttons must have a link associated with them");
                 UrlValidation.ValidateButton(Url);