convert dashboard-pages to tailwind

[kayceeDev]

No description provided.

[whateverfw]

@kayceeDev sync with main please

[kayceeDev]

@kayceeDev sync with main please

I will definitely do that in my next push.

[kayceeDev]

@whateverfw The main is also broken. but I will try and fix them.

[whateverfw]

@whateverfw The main is also broken. but I will try and fix them.

what main? do you mean that main branch also has issue on this pages?

It can be the case, because we are in the process of tailwind migration, so maybe someone somehow broke those pages. That's basically why we have this ticket to fix exactly those pages and another ones are fixed by another devs.

[kayceeDev]

Yes, I will definitely fix them. In the mobile, I see a drop down menu popping out. I think the active state changes to true on mobile..

[whateverfw]

Yes, I will definitely fix them. In the mobile, I see a drop down menu popping out. I think the active state changes to true on mobile..

if that's blocking you and it is not a quick fix, just put some false state for now and concentrate on your pages, we'll fix it separately

[kayceeDev]

Alright. Thanks

[kayceeDev]

So the broken you are referring to for mobile and desktop, is it during the break points?

[whateverfw]

@kayceeDev I just attached all the screenshot, in general on few pages on desktop only cards styles are broken, however position history page has broken both desktop in mobile

and in general each page's mobile is not correct, as you can see on screenshots. I don't see any breakpoints for responsiveness in code

[kayceeDev]

I will fix it. Thank you for the screenshots. I didn't clearly see the mobile completely cos of the overlay that comes up whenever you go to mobile.

[whateverfw]

I see that mobile styles are not yet ideal, but better, pls take a look carefully and fix.

[whateverfw]

please revert changes on in this file

[kayceeDev]

Alright. I will. Remove it from my commit

[kayceeDev]

@whateverfw all fixes has been resolved and everything looks good on all devices now

[whateverfw]

Please make sure to go through figma and make sure those pages looks like that.

[whateverfw]

[whateverfw]

still appears like that @kayceeDev

[whateverfw]

take a look how mobile cards positioned in figma, also the main card padding slightly different and not all values are displayed

[whateverfw]

clearly doesn't look like in figma (cards)

[whateverfw]

@kayceeDev

[whateverfw]

please seed this table with data (there is a command in README.md) and make sure it look good on both desktop and mobile

[whateverfw]

still do not match figma desktop/mobile

[whateverfw]

@kayceeDev

[kayceeDev]

Some of the components on mobile has extra buttons
For example the deposit on mobile have a cancel button
Am I expected to add it in this migration or just make the existing components be as they are in the figma

[kayceeDev]

Please clarify. Because some of the differences I see on mobile is the cards I turned to column instead of rows

[kayceeDev]

Please clarify. Because some of the differences I see on mobile is the cards I turned to column instead of rows

[whateverfw]

Some of the components on mobile has extra buttons For example the deposit on mobile have a cancel button Am I expected to add it in this migration or just make the existing components be as they are in the figma

make existing, if it didn't exist before - do not add

[whateverfw]

Please clarify. Because some of the differences I see on mobile is the cards I turned to column instead of rows

yeah, so, that was exactly one of the points, which aren't like in Figma

[whateverfw]

still various broken styles or different looks from figma/previous version.

[whateverfw]

@kayceeDev
I see that direction for fixes of position history is incorrect, please follow the figma, we had 3 columns and then action button that triggers a modal with the rest of the fields...

[kayceeDev]

@whateverfw fixed

[djeck1432]

Looks good to me