Support for hourly data for precipitation graph. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 28, 2018
dmcinnes
requested changes
Dec 3, 2018
| this.isAnyPrecipitation(minutely))) { | ||
| wrapper.appendChild(this.renderPrecipitationGraph()); | ||
| this.isAnyPrecipitation(minutely,hourly))) { | ||
| wrapper.appendChild(this.renderPrecipitationGraph(minutely?this.weatherData.minutely.data:this.weatherData.hourly.data)); |
There was a problem hiding this comment.
Will you please extract the minutely?... ternary to another line? Also add spaces between all parts for readability.
| @@ -195,8 +195,8 @@ Module.register("MMM-forecast-io", { | |||
|
|
|||
| if (this.config.alwaysShowPrecipitationGraph || | |||
| (this.config.enablePrecipitationGraph && | |||
| this.isAnyPrecipitation(minutely))) { | |||
| wrapper.appendChild(this.renderPrecipitationGraph()); | |||
| this.isAnyPrecipitation(minutely,hourly))) { | |||
There was a problem hiding this comment.
Will you add a space after the comma?
| isAnyPrecipitation: function (minutely) { | ||
| if (!minutely) { | ||
| isAnyPrecipitation: function (minutely,hourly) { | ||
| if (!minutely&&!hourly) { |
| return false; | ||
| } | ||
| var data = this.weatherData.minutely.data; | ||
| var data = minutely?this.weatherData.minutely.data:this.weatherData.hourly.data; |
dmcinnes
requested changes
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to get the precipitation graph when minutely data are not available.