ci(docker): add missing ca-certificates and SSL certs copy

[steebchen]

Description

Ensure ca-certificates are installed and copied to the base image to support secure HTTPS connections where required.

Related issue

Tests

• Yes
• No, because they aren't needed
• No, because I need help

Added to documentation?

• README.md
• Dojo Book
• No documentation needed

Checklist

• I've formatted my code (scripts/prettier.sh, scripts/rust_fmt.sh, scripts/cairo_fmt.sh)
• I've linted my code (scripts/clippy.sh, scripts/docs.sh)
• I've commented my code
• I've requested a review after addressing the comments

Summary by CodeRabbit

• Security Improvements
  • Enhanced SSL certificate handling in the container build process
  • Improved container security by properly copying SSL certificates between build stages

[coderabbitai]

Walkthrough

Ohayo, sensei! The Dockerfile has been updated to improve SSL certificate handling during the container build process. The changes involve adding ca-certificates to the package installation in the builder stage and introducing a new COPY command to transfer SSL certificates from the builder stage to the final image, ensuring proper SSL connection management.

Changes

File	Change Summary
Dockerfile	- Added ca-certificates to package installation in builder stage - Introduced new COPY command to transfer SSL certificates between stages

The modifications are focused on enhancing the container's ability to handle SSL connections by ensuring the necessary certificates are available throughout the build and runtime processes.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

Dockerfile (1)

3-3: Ohayo! Good addition of ca-certificates, sensei! Consider optimizing the layer size.

The addition of ca-certificates is well-placed with other system packages. However, we can optimize the image size by cleaning up apt cache.

-RUN apt-get update && apt install -y git libtool automake autoconf make tini ca-certificates
+RUN apt-get update && apt install -y git libtool automake autoconf make tini ca-certificates \
+    && rm -rf /var/lib/apt/lists/*

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d50627b and a219119.

📒 Files selected for processing (1)

• Dockerfile (2 hunks)

🔇 Additional comments (1)

Dockerfile (1)

19-20: LGTM! Let's verify SSL cert accessibility, sensei!

The SSL certificate copying is correctly implemented using multi-stage build pattern. To ensure everything works as expected, we should verify that the certificates are accessible in the final image.

Run this test script in your local environment:

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.23%. Comparing base (0cb5923) to head (a219119).
Report is 100 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2914      +/-   ##
==========================================
- Coverage   55.50%   55.23%   -0.27%     
==========================================
  Files         434      449      +15     
  Lines       54295    58331    +4036     
==========================================
+ Hits        30137    32220    +2083     
- Misses      24158    26111    +1953     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.