feat: add explorer flag and build folder #2997
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glihm
reviewed
Feb 6, 2025
| } | ||
|
|
||
| impl NodeArgs { | ||
| pub async fn execute(&self) -> Result<()> { | ||
| // Initialize logging first |
There was a problem hiding this comment.
Suggested change
| // Initialize logging first |
Those comments don't add any relevant information.
| self.init_logging()?; | ||
|
|
||
| // Finally start the node |
There was a problem hiding this comment.
Suggested change
| // Finally start the node |
| }) | ||
| } | ||
|
|
||
| pub fn start(&self) -> Result<()> { |
There was a problem hiding this comment.
Would it be possible at this point to inject the Katana url (which can be modified by the user) into the env somehow, which would make the explorer always indexing by default the katana that has just started?
| _ => "application/octet-stream", | ||
| }; | ||
|
|
||
| let response = Response::from_data(content) |
There was a problem hiding this comment.
Even with those headers, when I start Katana without providing the build path into explorer repo (/dist), I have those errors:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add a explorer in the dojo toolchain by spawning a vite react project on spinning up a katana instance
Related issue
Tests
Added to documentation?
Checklist
scripts/prettier.sh,scripts/rust_fmt.sh,scripts/cairo_fmt.sh)scripts/clippy.sh,scripts/docs.sh)