-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #123 #124
base: master
Are you sure you want to change the base?
Fixes #123 #124
Conversation
…the maximum paragraph count.
You can see it in action here http://dennis.dieploegers.de/doku.php/my2cents/start |
|
||
for ($a=0; $a<$open_sects; $a++) { | ||
|
||
$ins[] = array('section_close', array()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there can't be more than one open section (sections aren't nested) but paragraphs can occur e.g. inside instructions from the wrap plugin. I fear the best we can do is keeping track of all possible instructions we know.
When only a certain number of paragraphs is included I think this should be the same as including only one section, this is in Apart from that and the possible problem with instructions that aren't closed I think this can be merged. Thank you very much for the pull request! |
Thanks and you're welcome. |
Do you merge it then? :) |
Hey, @michitux. What about this pull request? |
This is an idea for #123: I've added a "paragraphs=x" parameter. The plugin then skips all other instructions after the maximum paragraph count (identified when finding a "p_open" instruction) and adds the read-more link.