Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: subfile overrides #2941

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

adamSherwoodGenieAI
Copy link
Contributor

closes #2938

  • adds an overrides optional parameter to Compiler.compile and the Packer methods
  • adds tests for the overrides parameter
  • updates Packer usage docs
    • adds usage example for Packer.toString and Packer.toStream which were undocumented
    • adds brief explanation for the optional prettify parameter which was undocumented
    • adds usage example for overrides parameter

Let me know if this needs anything else

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (eb2174e) to head (e53209f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2941   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          286       286           
  Lines         8363      8390   +27     
  Branches      1409      1410    +1     
=========================================
+ Hits          8363      8390   +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamSherwoodGenieAI
Copy link
Contributor Author

@dolanmiu This is the PR related to that conversation we had in #2938

@dolanmiu dolanmiu merged commit 05fcf6e into dolanmiu:master Jan 27, 2025
8 checks passed
@dolanmiu
Copy link
Owner

Looks good, merged

@adamSherwoodGenieAI adamSherwoodGenieAI deleted the feat/subfile_overrides branch January 27, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extending zip output with more sub-files
2 participants