-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Sapient Guardian provider #413
Conversation
@caleblloyd, It will cover your contributions to all .NET Foundation-managed open source projects. |
|
File | Status | Preview URL | Details |
---|---|---|---|
Details | |||
entity-framework/core/providers/sapient-guardian/index.md | ✅Succeeded | ||
entity-framework/toc.md | ✅Succeeded |
- [Warning] The log line content 'W:\l5sz-s.openpublishing.build.ps1' can't be converted to log item. Details: {"message":"Inline code snippet is only allowed inside tables.","source":"Build Document.CompilePhaseHandlerWithIncremental.ConceptualDocumentProcessor.Build.BuildConceptualDocument","file":"entity-framework/64","line":"InvalidInlineCodeSnippet","date_time":"2017-06-13T19:09:36.0432714Z","message_severity":"warning"}
- [Warning] The log line content 'W:\l5sz-s.openpublishing.build.ps1' can't be converted to log item. Details: {"message":"Inline code snippet is only allowed inside tables.","source":"Build Document.CompilePhaseHandlerWithIncremental.ConceptualDocumentProcessor.Build.BuildConceptualDocument","file":"entity-framework/82","line":"InvalidInlineCodeSnippet","date_time":"2017-06-13T19:09:36.262022Z","message_severity":"warning"}
- [Warning] The log line content 'W:\l5sz-s.openpublishing.build.ps1' can't be converted to log item. Details: {"message":"Inline code snippet is only allowed inside tables.","source":"Build Document.CompilePhaseHandlerWithIncremental.ConceptualDocumentProcessor.Build.BuildConceptualDocument","file":"entity-framework/64","line":"InvalidInlineCodeSnippet","date_time":"2017-06-13T19:09:36.2776488Z","message_severity":"warning"}
- [Warning] The log line content 'W:\l5sz-s.openpublishing.build.ps1' can't be converted to log item. Details: {"message":"Inline code snippet is only allowed inside tables.","source":"Build Document.CompilePhaseHandlerWithIncremental.ConceptualDocumentProcessor.Build.BuildConceptualDocument","file":"entity-framework/82","line":"InvalidInlineCodeSnippet","date_time":"2017-06-13T19:09:36.2776488Z","message_severity":"warning"}
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.
@SapientGuardian want to check in with you on this first - do you also agree that it would be appropriate to remove the Sapient EF Connector from EF Official Documentation? |
@caleblloyd, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
👍 Yes, at this point I don't know of any reason to use it over Pomelo or the official MySql provider. |
@rowanmiller Could you please take a look at this PR? @SapientGuardian We also hope you can join us to maintain the mysql efcore provider. I've sent you invitation. |
Rowan switched off the EF team Maybe @divega can help? |
@caleblloyd @kagamine @SapientGuardian sorry for the delayed response and thanks for the fix. |
:) |
Sapient is showing a recommendation for it's users to switch to Pomelo for a MySql provider:
https://github.com/SapientGuardian/SapientGuardian.EntityFrameworkCore.MySql
It also looks like there's not an active maintainer working on a 2.0.0 upgrade:
SapientGuardian/SapientGuardian.EntityFrameworkCore.MySql#56