Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Sapient Guardian provider #413

Merged
merged 1 commit into from
Aug 6, 2017
Merged

Remove Sapient Guardian provider #413

merged 1 commit into from
Aug 6, 2017

Conversation

caleblloyd
Copy link
Contributor

@caleblloyd caleblloyd commented Jun 13, 2017

Sapient is showing a recommendation for it's users to switch to Pomelo for a MySql provider:

https://github.com/SapientGuardian/SapientGuardian.EntityFrameworkCore.MySql

It also looks like there's not an active maintainer working on a 2.0.0 upgrade:

SapientGuardian/SapientGuardian.EntityFrameworkCore.MySql#56

@dnfclas
Copy link

dnfclas commented Jun 13, 2017

@caleblloyd,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla2.dotnetfoundation.org.

It will cover your contributions to all .NET Foundation-managed open source projects.
Thanks,
.NET Foundation Pull Request Bot

@bradygaster-zz
Copy link

⚠️ Validation status: warnings

File Status Preview URL Details
⚠️Warning Details
entity-framework/core/providers/sapient-guardian/index.md ✅Succeeded
entity-framework/toc.md ✅Succeeded

  • [Warning] The log line content 'W:\l5sz-s.openpublishing.build.ps1' can't be converted to log item. Details: {"message":"Inline code snippet is only allowed inside tables.","source":"Build Document.CompilePhaseHandlerWithIncremental.ConceptualDocumentProcessor.Build.BuildConceptualDocument","file":"entity-framework/64","line":"InvalidInlineCodeSnippet","date_time":"2017-06-13T19:09:36.0432714Z","message_severity":"warning"}
  • [Warning] The log line content 'W:\l5sz-s.openpublishing.build.ps1' can't be converted to log item. Details: {"message":"Inline code snippet is only allowed inside tables.","source":"Build Document.CompilePhaseHandlerWithIncremental.ConceptualDocumentProcessor.Build.BuildConceptualDocument","file":"entity-framework/82","line":"InvalidInlineCodeSnippet","date_time":"2017-06-13T19:09:36.262022Z","message_severity":"warning"}
  • [Warning] The log line content 'W:\l5sz-s.openpublishing.build.ps1' can't be converted to log item. Details: {"message":"Inline code snippet is only allowed inside tables.","source":"Build Document.CompilePhaseHandlerWithIncremental.ConceptualDocumentProcessor.Build.BuildConceptualDocument","file":"entity-framework/64","line":"InvalidInlineCodeSnippet","date_time":"2017-06-13T19:09:36.2776488Z","message_severity":"warning"}
  • [Warning] The log line content 'W:\l5sz-s.openpublishing.build.ps1' can't be converted to log item. Details: {"message":"Inline code snippet is only allowed inside tables.","source":"Build Document.CompilePhaseHandlerWithIncremental.ConceptualDocumentProcessor.Build.BuildConceptualDocument","file":"entity-framework/82","line":"InvalidInlineCodeSnippet","date_time":"2017-06-13T19:09:36.2776488Z","message_severity":"warning"}

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@caleblloyd
Copy link
Contributor Author

@SapientGuardian want to check in with you on this first - do you also agree that it would be appropriate to remove the Sapient EF Connector from EF Official Documentation?

@dnfclas
Copy link

dnfclas commented Jun 13, 2017

@caleblloyd, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, .NET Foundation Pull Request Bot

@SapientGuardian
Copy link

👍 Yes, at this point I don't know of any reason to use it over Pomelo or the official MySql provider.

@yukozh
Copy link
Contributor

yukozh commented Jun 16, 2017

@rowanmiller Could you please take a look at this PR?

@SapientGuardian We also hope you can join us to maintain the mysql efcore provider. I've sent you invitation.

@caleblloyd
Copy link
Contributor Author

Rowan switched off the EF team

Maybe @divega can help?

@divega divega merged commit a4207f6 into dotnet:master Aug 6, 2017
@divega
Copy link
Contributor

divega commented Aug 6, 2017

@caleblloyd @kagamine @SapientGuardian sorry for the delayed response and thanks for the fix.

@yukozh
Copy link
Contributor

yukozh commented Aug 6, 2017

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants