Fire GLFW joystick events (#1992)

* Fire GLFW joystick events * Sneak in a fix for #1862 as well
dotnet · Mar 21, 2024 · d891960 · d891960
1 parent 7c38fa2
commit d891960
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 5 deletions.
diff --git a/src/Input/Silk.NET.Input.Glfw/GlfwJoystick.cs b/src/Input/Silk.NET.Input.Glfw/GlfwJoystick.cs
@@ -57,17 +57,29 @@ public unsafe void Update()
 
             for (var i = 0; i < btnCount; i++)
             {
-                ((Button[]) Buttons)[i] = new Button(ButtonName.Unknown, i, btn[i] == (int) InputAction.Press);
+                var thisBtn = new Button(ButtonName.Unknown, i, btn[i] == (int) InputAction.Press);
+                var shouldInvoke = ((Button[]) Buttons)[i].Pressed != thisBtn.Pressed;
+                ((Button[]) Buttons)[i] = thisBtn;
+                if (shouldInvoke)
+                {
+                    (thisBtn.Pressed ? ButtonDown : ButtonUp)?.Invoke(this, thisBtn);
+                }
             }
 
             for (var i = 0; i < axisCount; i++)
             {
-                ((Axis[]) Axes)[i] = new Axis(i, axes[i]);
+                var thisAxis = new Axis(i, Deadzone.Apply(axes[i]));
+                var shouldInvoke = ((Axis[]) Axes)[i].Position != thisAxis.Position;
+                ((Axis[]) Axes)[i] = thisAxis;
+                if (shouldInvoke)
+                {
+                    AxisMoved?.Invoke(this, thisAxis);
+                }
             }
 
             for (var i = 0; i < hatCount; i++)
             {
-                ((Hat[]) Hats)[i] = new Hat
+                var thisHat = new Hat
                 (
                     i, hats[i] switch
                     {
@@ -83,6 +95,12 @@ public unsafe void Update()
                         _ => Position2D.Centered
                     }
                 );
+                var shouldInvoke = ((Hat[]) Hats)[i].Position != thisHat.Position;
+                ((Hat[]) Hats)[i] = thisHat;
+                if (shouldInvoke)
+                {
+                    HatMoved?.Invoke(this, thisHat);
+                }
             }
 
             if (!_connected)

diff --git a/src/Windowing/Silk.NET.Windowing.Sdl/SdlWindow.cs b/src/Windowing/Silk.NET.Windowing.Sdl/SdlWindow.cs
@@ -451,8 +451,8 @@ protected override void CoreInitialize(ViewOptions opts)
             };
             CoreInitialize
             (
-                opts, flags, InitialMonitor?.Bounds.Origin.X + Position.X,
-                InitialMonitor?.Bounds.Origin.Y + Position.Y, Size.X, Size.Y, Title, SharedContext
+                opts, flags, (InitialMonitor?.Bounds.Origin.X ?? 0) + _extendedOptionsCache.Position.X,
+                (InitialMonitor?.Bounds.Origin.Y ?? 0) + _extendedOptionsCache.Position.Y, Size.X, Size.Y, Title, SharedContext
             );
         }
     }