-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package update and central management #252
package update and central management #252
Conversation
@dotnet-policy-service agree |
Nice! Thanks @chr-ber |
Dang didn't recognize you from the pic Chris! ;) this makes things a lot easier to manage packages, thanks |
<PackageVersion Include="NuGet.Protocol" Version="6.8.0" /> | ||
<PackageVersion Include="RabbitMQ.Client" Version="6.8.1" /> | ||
<PackageVersion Include="Sentry" Version="4.0.0-beta.4" /> | ||
<PackageVersion Include="Sentry.AspNetCore" Version="$(SentryVersion)" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it would be nice to pull the property that sets this value also to this file. I believe it's set on a Directory.Build.props right now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bruno-garcia added a commit, all sentry versions should now be taken from the variable in Directory.Build.props
CI failed with
We changed some canvas stuff on the Sentry SDK but surprised this happened in CI since it should be pinned to the latest version. I'll fix it on another PR |
This pull request includes: