feature/streamline logging and exception messages #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chr-ber
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
=======================================
Coverage 93.24% 93.24%
=======================================
Files 27 27
Lines 429 429
Branches 33 33
=======================================
Hits 400 400
Misses 27 27
Partials 2 2 ☔ View full report in Codecov by Sentry. |
chr-ber
force-pushed
the
feature/streamline-logging
branch
from
9aaed08 to
3f28f2e
Compare
bruno-garcia
reviewed
Feb 7, 2024
| @@ -1,8 +1,8 @@ | |||
| using System.Text.RegularExpressions; | |||
There was a problem hiding this comment.
doesn't seem needed?
Suggested change
| using System.Text.RegularExpressions; |
There was a problem hiding this comment.
removed from the commit
chr-ber
force-pushed
the
feature/streamline-logging
branch
from
3f28f2e to
8805145
Compare
bruno-garcia
approved these changes
Feb 7, 2024
|
Thanks again Chris! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important aspect of this pull request is the addition of a missing string interpolation symbol to one of the log messages, found in the first commit -> c50e6da. I encountered this issue when running the project locally.
While I was at it, I also reviewed all log and exception messages in the project and unified their style. I understand if that seems a bit unnecessary; I guess I got carried away. 😅 I believe the first commit should be accepted at the very least. If the rest ends up in the 🗑️. No harm done!
In general, I tried to apply these simple rules: