fix cluster: migration crash fix #4508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: adi_holden <[email protected]>
Signed-off-by: adi_holden <[email protected]>
BorysTheDev
approved these changes
Jan 27, 2025
romange
reviewed
Jan 27, 2025
| @@ -716,14 +716,15 @@ void DbSlice::FlushSlotsFb(const cluster::SlotSet& slot_ids) { | |||
| PrimeTable* table = GetTables(db_index).first; | |||
|
|
|||
| auto iterate_bucket = [&](DbIndex db_index, PrimeTable::bucket_iterator it) { | |||
| it.AdvanceIfNotOccupied(); | |||
There was a problem hiding this comment.
Have you considered fixing it in dash code? @adiholden
seems weird that callbacks are called with invalid iterators and you need to check them or advance them yourself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4455
This PR:
The bug - calling bucket iterator get version will fail if bucket iterator is not valid. This case can happen when we have few callbacks executed on flush changes on earlier buckets. If the first one will remove all data from the bucket, the next call to the next registered callback will call Seek2Occupied and if the bucket is empty the iterator will be invalid.