Fix pre-prompt ccds version error #426
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisjkuch
commented
Feb 17, 2025
jayqi
reviewed
Feb 17, 2025
hooks/pre_prompt.py
Outdated
Comment on lines
3
to
6
| from ccds import __version__ | ||
|
|
||
| if __name__ == "__main__": | ||
| if version < "2.0.1": | ||
| if __version__ < "2.0.1": |
There was a problem hiding this comment.
Is there any scenario where this would still break? You could potentially put this in a try-except.
There was a problem hiding this comment.
Yeah I think that's a good idea regardless.
…and removing any module-level imports from pre-prompt
chrisjkuch
force-pushed
the
425-version-bugfix
branch
from
4157c7c to
131b123
Compare
pjbull
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue introduced in #336 (hotfixed in #427 ) that added a pre-prompt hook to warn about the newly introduced versioning system.
However, the pre-prompt script was unable to access certain module-level imports from the ccds package.
(I'm still trying to figure out / think about why that's the case)I think this is because we simultaneously changed the versioning structure and mechanism in #336 by adding aversion.pythat computed the package version, and people with the old version ofccdsinstalled were looking for the version ofccdsin a module that didn't exist in their version of the package.Migrating version extraction from a separate
version.pymodule into__init__.pyseems to fix this, since the version can be determined directly by importlib without needing separate imports from the ccds module.