Adding Docker-Compose #53
Conversation
abhinavtripathy
added
backend
dependencies
README.md
Outdated
| ``` | ||
| sudo bash docker_shell.sh | ||
| ``` | ||
| If you want to access the rails console, then run the following comand after the previous one: |
There was a problem hiding this comment.
This is definitely not a priority but could you fix the spelling on command?
docker-compose.yml
Outdated
| volumes: | ||
| - ./:/usr/src/app | ||
| ports: | ||
| - "3000:3000" |
There was a problem hiding this comment.
Silly EOL error that might return to haunt us later.
Consider using a Ruby formatter in a .gitattribute file that will automatically handle this, along with other formatting issues, when the changes are pushed to our remote.
For Python, I use a PEP-8 formatter called Black; I found this for Ruby, maybe this'll be helpful in our case.
docker/Dockerfile
Outdated
| EXPOSE 3000 | ||
|
|
||
| # Default command that runs when the container starts | ||
| CMD ["bash", "docker/docker_set_up.sh"] |
docker/docker_set_up.sh
Outdated
| @@ -0,0 +1,3 @@ | |||
| rm tmp/pids/server.pid | |||
| yarn install --check-files | |||
| bundle exec rails server -b 0.0.0.0 | |||
There was a problem hiding this comment.
@abhinavtripathy are we starting the server at 0.0.0.0 or does this reference the port specified in docker-compose.yml
There was a problem hiding this comment.
it references the port specified in docker-compose
docker_shell.sh
Outdated
| @@ -0,0 +1 @@ | |||
| docker-compose exec rails ${@:-/bin/bash} | |||
|
Looks great!! |
Added docker-compose with rails and postgres containers. Added shell scripts to access both containers. Added Dockerfile with yarn support and added db_setup script. Added documentation to readme for building and running containers with common errors. This closes #17