Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make function static #140

Merged
merged 1 commit into from
Jan 21, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/storage/delta_schema_entry.cpp
Original file line number Diff line number Diff line change
@@ -95,7 +95,7 @@ void DeltaSchemaEntry::Alter(CatalogTransaction transaction, AlterInfo &info) {
throw NotImplementedException("Delta tables do not support altering");
}

bool CatalogTypeIsSupported(CatalogType type) {
static bool CatalogTypeIsSupported(CatalogType type) {
switch (type) {
case CatalogType::TABLE_ENTRY:
return true;

Unchanged files with check annotations Beta

case ffi::Level::ERROR:
return LogLevel::LOG_ERROR;
}
}

Check warning on line 681 in src/delta_utils.cpp

GitHub Actions / Generated Tests (Linux)

control reaches end of non-void function [-Wreturn-type]

Check warning on line 681 in src/delta_utils.cpp

GitHub Actions / Generated Tests (Linux)

control reaches end of non-void function [-Wreturn-type]

Check warning on line 681 in src/delta_utils.cpp

GitHub Actions / Minio (local S3 test server) tests (Linux)

control reaches end of non-void function [-Wreturn-type]

Check warning on line 681 in src/delta_utils.cpp

GitHub Actions / Minio (local S3 test server) tests (Linux)

control reaches end of non-void function [-Wreturn-type]

Check warning on line 681 in src/delta_utils.cpp

GitHub Actions / Azurite (local azure test server) tests (Linux)

control reaches end of non-void function [-Wreturn-type]

Check warning on line 681 in src/delta_utils.cpp

GitHub Actions / Azurite (local azure test server) tests (Linux)

control reaches end of non-void function [-Wreturn-type]

Check warning on line 681 in src/delta_utils.cpp

GitHub Actions / Performance Regression Tests

control reaches end of non-void function [-Wreturn-type]

Check warning on line 681 in src/delta_utils.cpp

GitHub Actions / Performance Regression Tests

control reaches end of non-void function [-Wreturn-type]

Check warning on line 681 in src/delta_utils.cpp

GitHub Actions / Build extension binaries / Windows (windows_amd64, x64-windows-static-md)

'duckdb::LoggerCallback::GetDuckDBLogLevel': not all control paths return a value [D:\a\duckdb-delta\duckdb-delta\build\release\extension\delta\delta_extension.vcxproj]

Check warning on line 681 in src/delta_utils.cpp

GitHub Actions / Build extension binaries / Windows (windows_amd64, x64-windows-static-md)

'duckdb::LoggerCallback::GetDuckDBLogLevel': not all control paths return a value [D:\a\duckdb-delta\duckdb-delta\build\release\extension\delta\delta_loadable_extension.vcxproj]
LoggerCallback &LoggerCallback::GetInstance() {
static LoggerCallback instance;