Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI test fixes #3794

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

UI test fixes #3794

wants to merge 1 commit into from

Conversation

samsymons
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/414235014887631/1209133157056550/f
Tech Design URL:
CC:

Description:

This PR fixes up the fingerprinting UI tests, which were looking for the wrong bookmark title.

Steps to test this PR:

  1. Check this branch out with a clean simulator
  2. Run FingerprintingUITests and check that they pass

Definition of Done (Internal Only):

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons requested review from a team and diegoreymendez and removed request for a team January 12, 2025 20:19
Copy link
Contributor

@diegoreymendez diegoreymendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fingerprinting UI tests pass and I see no breakage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants