Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live pixel validation: remove cache-buster before parameter validation #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Live pixel validation: remove cache-buster before parameter validation #6

wants to merge 2 commits into from

Conversation

sammacbeth
Copy link
Collaborator

  • On most platforms, we send a cache buster string with pixel requests, e.g. /t/pixel?12345&param=1
  • When validating URLs including this string, the current validator assumes that this is a parameter, and thus marks the parameters as invalid.
  • We can parse the cache-buster out before parsing the URL query parameters to prevent this.

@sammacbeth sammacbeth requested a review from nshuba January 10, 2025 14:13
@sammacbeth sammacbeth force-pushed the sam/validator-fixes branch 2 times, most recently from ab2adea to a65aa6a Compare January 10, 2025 14:20
nshuba
nshuba approved these changes Jan 12, 2025
View reviewed changes
Copy link
Collaborator

@nshuba nshuba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nshuba nshuba nshuba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sammacbeth @nshuba