Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/ed25519-support #148

Merged
merged 10 commits into from
Dec 4, 2024
Merged

feat/ed25519-support #148

merged 10 commits into from
Dec 4, 2024

Conversation

MasterKale
Copy link
Collaborator

@MasterKale MasterKale commented Dec 4, 2024

This PR adds the ability to indicate support for the Ed25519 (-8) public key credential algorithm during registration:

Screenshot 2024-12-04 at 11 41 15 AM

This algorithm is also enabled by default and is placed first to encourage more authenticators to use it if they support it:

{
  // ...
  "pubKeyCredParams": [
    { "type": "public-key", "alg": -8 },
    { "type": "public-key", "alg": -7 },
    { "type": "public-key", "alg": -257 }
  ],
  // ...
}

I'm also including some refactor to remove the last usage of Pydantic, and also started writing some unit tests to stop being so irresponsible with this website.

@MasterKale MasterKale merged commit fad5eb3 into master Dec 4, 2024
1 check passed
@MasterKale MasterKale deleted the feat/ed25519-support branch December 4, 2024 23:03
@MasterKale MasterKale changed the title Support use of Ed25519 during registration feat/ed25519-support Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant