Add custom_fields to the vlan datasource #395
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-willem
changed the title
|
Hi! Thanks for your MR! |
|
Hi ! Sorry for taking so long answering your request. While I might be able to identify the right code and duplicate it to grab custom fields, I'm evidently not Go-fluent enough to write a unit-test requiring to setup the whole thing. If anyone'd like to help over here and/or take over the PR, feel free ! |
|
Hi, is there any chance of seeing this PR merged any day, or anybody taking up the quick patch into something better ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netbox has build-in customfields management, while it seems from PR #143 that general custom fields deployment (specifically within resources) seems complicated, adding them to the datasources is a minium enabling Netbox
users to pass their specific data onwards.
Tests seem to be passing :
--> make test
go test netbox/*.go -timeout=120s -parallel=4 -cover
go: downloading github.com/stretchr/testify v1.8.2
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/pmezard/go-difflib v1.0.0
ok command-line-arguments 0.365s coverage: 2.9% of statements