Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dataSourceNetboxVlans] - Add netbox_vlan.id in netbox_vlans.vlans DataSources #662

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

rypti
Copy link

@rypti rypti commented Dec 6, 2024

"update(dataSourceNetboxVlans): Add netbox_vlan.id info in return info of netbox_vlans.vlans"

Add netbox_vlan.id to "netbox_vlans (Data Source) > Nested Schema for vlans"
Allowing to use netbox_vlans to update Ressources and DataSources when "netbox_vlan" can't be used. (Identical vlan infos or only Read-Only info differentiates )

Can also be used with Vlans that didn't get created with the provider.

@fbreckle
Copy link
Collaborator

fbreckle commented Jan 7, 2025

I feel like just adding "assigned_id" as an output field is not very user-friendly. The AssignedObjectType field should be read and then set fields assigned_device_id, assigned_virtual_machine_id and possibly also assigned_object_type should be set in order to return all relevant info.

@rypti
Copy link
Author

rypti commented Jan 15, 2025

Hello,
Sorry, those commit were not meant to end up in the pull request only the modifications on "dataSourceNetboxVlans" are the target of this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants