-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update auth.php and theme_handler.php to us ea bootstrap 5 admin theme and comply to use BS5 as it should. #5373
base: master
Are you sure you want to change the base?
Conversation
Free the use of a admin theme with the name bootsrap5, it works perfectly when this is changed!
The front theme config does not give real tabs when you use bootstrap 5, it is really a not working as it should without..
Happy New Year @Alex-e107nl ! Thank you for this. I didn't want to allow BS5 until the bootstrap5 theme was fully compatible with the admin area. I believe there's quite a few javascript components in |
Dear Cameron,. also for you a good and healthy 2025, what matters to me is that the auth.php is adjusted, the rest is no longer necessary, by applying an admin_theme_library.php I have it 90% done now, and believe me if you have worked with the new admin theme you do not want to go back... I still have to solve some small things and then everything is functional, Jquery and BS5 work fine together, eventually everything has to be converted to Vanilla but I think there is someone with good knowledge of javascript to tackle this together :-) Teasers...... :-) |
Original files replaced, these do not give a error... ( https://github.com/FortAwesome/font-awesome-sass/tree/master/assets/fonts/font-awesome )
Nice work! I sent you a DM. 😉 |
? If you want to reach me, use mail, info*e107.nl, did not receive a DM... |
Added link classes and </a> for link in help text..
In both bootstrap 3 and 5 this is redundant, adjustment gives normal buttons below the avatar overview.
Icon - caption not inline, deleted icon in $caption and added $var['_extras_']['icon'] = e107::getParser()->toIcon('e-menus-24'); Solved...
Added .logcanvas so the width can be changed in admin_style.css (33ve is to much)
Motivation and Context
Without it you cannot use the bootstrap5 theme as admin theme and the tabs in the theme config (front and admin) does not give real tabs.
Description
admin/auth.php
theme_handler.php
<li class='active'><a data-toggle='tab' data-bs-toggle='tab' href='#core-thememanager-configure'>".LAN_CONFIGURE."</a></li>";
To
<li class='nav-item active'><a class='nav-link active' data-toggle='tab' data-bs-toggle='tab' href='#core-thememanager-configure'>".LAN_CONFIGURE."</a></li>";
$text .= "<li><a data-toggle='tab' data-bs-toggle='tab' href='#core-thememanager-customconfig'>".LAN_PREFS."</a></li>\n";
To
$text .= "<li class='nav-item'><a class='nav-link' data-toggle='tab' data-bs-toggle='tab' href='#core-thememanager-customconfig'>".LAN_PREFS."</a></li>\n";
text .= "<li><a data-toggle='tab' data-bs-toggle='tab' href='#core-thememanager-help'>".LAN_HELP."</a></li>\n";
To
$text .= "<li class='nav-item'><a class='nav-link' data-toggle='tab' data-bs-toggle='tab' href='#core-thememanager-help'>".LAN_HELP."</a></li>\n";
How Has This Been Tested?
On a live server: e107 - Version 2.4.0 (git) - Server - Apache/2 - PHP Version - 8.1.30 - MySQL - 10.5.27-MariaDB - PDO: Enabled
Mode: NO_ENGINE_SUBSTITUTION - Charset - utf-8 - Server Time - Wednesday 25 December 2024 - 21:33
Types of Changes
Checklist