Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare CRAN release #369

Open
wants to merge 41 commits into
base: main
Choose a base branch
from
Open

Prepare CRAN release #369

wants to merge 41 commits into from

Conversation

strengejacke
Copy link
Member

@strengejacke strengejacke commented Jan 27, 2025

@DominiqueMakowski
Copy link
Member

package modelbased_0.9.0.tar.gz does not pass the incoming checks automatically, please see the following pre-tests (additional issue checks):
Windows: https://win-builder.r-project.org/incoming_pretest/modelbased_0.9.0_20250128_094940/Windows/00check.log
Status: 1 ERROR, 1 NOTE
Debian: https://win-builder.r-project.org/incoming_pretest/modelbased_0.9.0_20250128_094940/Debian/00check.log
Status: 1 ERROR, 1 NOTE

@strengejacke
Copy link
Member Author

We have to wait for marginaleffects 😎

@strengejacke
Copy link
Member Author

I've added a todo list that we need to finish before we submit

@strengejacke
Copy link
Member Author

One thing I always forget is that estimate_relation() and alike have by not at 2nd, but 3rd position. The second argument is data. For estimate_means() and alike, by is the second argument.

Should we harmonize this? Will be a breaking change, but if we decide to do so, now would be a good opportunity, I guess.

@vincentarelbundock
Copy link
Contributor

FYI, marginaleffects 0.25.0 is on CRAN (source only, bin coming)

@DominiqueMakowski
Copy link
Member

Please see the problems shown on
https://cran.r-project.org/web/checks/check_results_modelbased.html.

Please correct before 2025-02-24 to safely retain your package on CRAN.

@strengejacke
Copy link
Member Author

Yes, that's expected. We are in principle ready to submit, question is whether you would like to address one, two or none of the above mentioned issues? I could implement them later this day

@strengejacke
Copy link
Member Author

Ok, changed option to "average". What about #373? Any opinions right now, or would you like to submit this version?

@strengejacke
Copy link
Member Author

Local checks all passed, just submitted to win-builder

@DominiqueMakowski
Copy link
Member

https://win-builder.r-project.org/ePxCxEcv5kw4
The files will be removed after roughly 72 hours.
Installation time in seconds: 7
Check time in seconds: 129
Status: OK

all pass

@strengejacke
Copy link
Member Author

#373 or submit, you decide! :-)
Would be great to have modelbased on CRAN this week, because insight and ggeffects also need to be fixed, but require modelbased on CRAN first. ^^

@strengejacke
Copy link
Member Author

Hope it's not too late to fix #377? Since the transform argument is no longer used, we can use it for (back-) transforming the predictions.

@strengejacke
Copy link
Member Author

Ok, the final fine-tuning is done, I think you can submit...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants