GLSP-1388 Enhance extensibility of ContainerManager
#385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndoschek
requested review from
tortmayr and
martin-fleck-at
and removed request for
tortmayr
- Added IContainerManager interface for easier customization - Consume IContainerManager for dependency injection - Extract isCreationAllowed submethod for element insertion checks Resolves eclipse-glsp/glsp#1388
martin-fleck-at
requested changes
Aug 20, 2024
packages/client/src/features/tools/node-creation/node-creation-module.ts
Outdated
Show resolved
Hide resolved
packages/client/src/features/tools/node-creation/container-manager.ts
Outdated
Show resolved
Hide resolved
- Ensure backward compatibility for ContainerManager binding by using bindAsService. - Make isCreationAllowed public and reuse in KeyboardPointerPosition (accessibility tools)
martin-fleck-at
approved these changes
Aug 21, 2024
|
Thank you for the review @martin-fleck-at! |
holkerveen
pushed a commit
to holkerveen/glsp-client
that referenced
this pull request
Dec 21, 2024
* GLSP-1388 Enhance extensibility of `ContainerManager` - Added IContainerManager interface for easier customization - Consume IContainerManager for dependency injection - Extract isCreationAllowed submethod for element insertion checks Resolves eclipse-glsp/glsp#1388 * Address review comments - Ensure backward compatibility for ContainerManager binding by using bindAsService. - Make isCreationAllowed public and reuse in KeyboardPointerPosition (accessibility tools)
holkerveen
pushed a commit
to holkerveen/glsp-client
that referenced
this pull request
Dec 21, 2024
* GLSP-1388 Enhance extensibility of `ContainerManager` - Added IContainerManager interface for easier customization - Consume IContainerManager for dependency injection - Extract isCreationAllowed submethod for element insertion checks Resolves eclipse-glsp/glsp#1388 * Address review comments - Ensure backward compatibility for ContainerManager binding by using bindAsService. - Make isCreationAllowed public and reuse in KeyboardPointerPosition (accessibility tools)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Resolves eclipse-glsp/glsp#1388
How to test
Node creation should work as before, this should not impact the functionality at all.
Follow-ups
--
Changelog