Check for results of List operations in addCommand #1454

eclipse-paho · Dec 16, 2024 · ebea1c5 · ebea1c5
1 parent 2793113
commit ebea1c5
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/src/MQTTAsyncUtils.c b/src/MQTTAsyncUtils.c
@@ -829,11 +829,19 @@ int MQTTAsync_addCommand(MQTTAsync_queuedCommand* command, int command_size)
 			rc = MQTTASYNC_COMMAND_IGNORED;
 		}
 		else
-			ListInsert(MQTTAsync_commands, command, command_size, MQTTAsync_commands->first); /* add to the head of the list */
+		{
+			ListElement* result = ListInsert(MQTTAsync_commands, command, command_size, MQTTAsync_commands->first); /* add to the head of the list */
+			if (result == NULL)
+				rc = PAHO_MEMORY_ERROR;
+		}
 	}
 	else
 	{
-		ListAppend(MQTTAsync_commands, command, command_size);
+		if (ListAppend(MQTTAsync_commands, command, command_size) == NULL)
+		{
+			rc = PAHO_MEMORY_ERROR;
+			goto exit;
+		}
 #if !defined(NO_PERSISTENCE)
 		if (command->client->c->persistence)
 		{