New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shall we switch the templates to use property injection outside the constructor #66

Open

JonasHelming opened this issue Jun 22, 2020 · 1 comment

Labels

Contributor

JonasHelming commented Jun 22, 2020 •

edited

Loading

as highlighted in the coding guidlines. Affects at least "hello world" and "backend", others to be checked...

https://github.com/eclipse-theia/theia/wiki/Coding-Guidelines#property-injection

JonasHelming mentioned this issue

Added backend communication template #65

Merged

Contributor Author

JonasHelming commented Jun 22, 2020

What I actually do not like about the field injection is that is does not break the contract :-)
Meaning: you add a "silent" dependency

vince-fugnitto mentioned this issue

Workspace must be open to create example file #88

Merged

vince-fugnitto added the proposal label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment