Added backend communication template #65
Conversation
src/app/index.ts
Outdated
| @@ -130,6 +131,7 @@ module.exports = class TheiaExtension extends Base { | |||
| { value: ExtensionType.HelloWorld, name: 'Hello World' }, | |||
| { value: ExtensionType.Widget, name: 'Widget' }, | |||
| { value: ExtensionType.LabelProvider, name: 'LabelProvider' }, | |||
| { value: ExtensionType.Backend, name: 'Backend communication' }, | |||
There was a problem hiding this comment.
minor: Backend Communication isntead of Backend communication
| @inject(HelloBackendWithClientService) private readonly helloBackendWithClientService: HelloBackendWithClientService, | ||
| @inject(HelloBackendService) private readonly helloBackendService: HelloBackendService, |
There was a problem hiding this comment.
The injections should be outside the constructor, they align with our coding guidelines:
There was a problem hiding this comment.
Not consistent with other examples, too, suggest to fix it for all (I can do that):
#66
templates/backend/contribution.ts
Outdated
| execute: () => this.helloBackendService.sayHelloTo('World').then(r => console.log(r)) | ||
| }); | ||
| } | ||
| } |
There was a problem hiding this comment.
minor: include a newline (same for all other files present in the pull-request).
fixed eclipse-theia#64 Signed-off-by: Jonas Helming <[email protected]>
JonasHelming
force-pushed
the
feature/#64
branch
from
eddb063 to
1418dd6
Compare
|
Can we merge this? |
Sure, I assume you want to do this for the whole repo instead of fixing this pull-request? |
yes... |
|
@marcdumais-work would you be able to perform a release? |
Sure thing! Give me a few minutes. |
|
|
|
thanks! |
fixed #64
Signed-off-by: Jonas Helming [email protected]
How to test: