Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set request limits for operator to ensure QOS Class #90

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sgraband
Copy link
Contributor

No description provided.

Copy link
Contributor

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have one comment. Also, just a heads-up that I rebased the changes.

@@ -106,3 +106,5 @@ spec:
imagePullSecrets:
- name: {{ tpl (.Values.operator.imagePullSecret | toString) . }}
{{- end }}
requestsMemory: {{ tpl (.Values.operator.requestsMemory | toString) . }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be similar to: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#example-1

So something like this?

    resources:
      requests:
        memory: {{ tpl (.Values.operator.requestsMemory | toString) . }}
        cpu: {{ tpl (.Values.operator.requestsCpu | toString) . }}

I also think the nesting level might be wrong, this should go under containers -> operator-container on the same level as image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants