Operator should not get hostname from app definitions #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove hostname from app definitions - Increase app definition spec version to v6beta - Adapt operator to get hostname as command line parameter Contributed on behalf of STMicroelectronics Signed-off-by: Lucas Koehler <[email protected]>
Contributed on behalf of STMicroelectronics Signed-off-by: Lucas Koehler <[email protected]>
sgraband
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
How to test
First, check out the corresponding branch 189-app-defs-remove-host (see PR eclipse-theia/theia-cloud-helm#30) from the theia-cloud-helm repo to get the required helm changes.
Second, use one of the terraform test configurations for try now. As usual, the configuration
0_minikube-setupand1_theia-cloud-baseneed to be installed first. Afterwards, install one of2-01_try-nowor2-03_try-now_paths. The latter is the new config using paths.Part of #189
Contributed on behalf of STMicroelectronics
Signed-off-by: Lucas Koehler [email protected]