Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependencies #345

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Update Dependencies #345

merged 2 commits into from
Aug 23, 2024

Conversation

jfaltermeier
Copy link
Contributor

@jfaltermeier jfaltermeier commented Aug 21, 2024

Java

Chosen versions for k8s client and quarkus mainly based on the latest Webhook Framework: https://mvnrepository.com/artifact/io.javaoperatorsdk/kubernetes-webhooks-framework-core/1.1.4

-> uses kubernetes client 6.12.1
-> quarkus 3.11.3 uses 6.12.1

This is the test matrix for the client 6.12.1:
https://github.com/fabric8io/kubernetes-client/blob/e4ddf5596385374fa2506ecf255b185629bc0b2e/.github/workflows/e2e-tests.yml#L71

Node

Updated open api generator and axios
-> common library should be tested before merging

Updated express
-> monitors should be tested


Contributed on behalf of STMicroelectronics

@jfaltermeier jfaltermeier force-pushed the jf/update-deps branch 6 times, most recently from 2165b3c to a5c4f62 Compare August 21, 2024 12:38
@jfaltermeier jfaltermeier changed the title WIP: Update Java Dependencies Update Java Dependencies Aug 22, 2024
Contributed on behalf of STMicroelectronics
@jfaltermeier jfaltermeier changed the title Update Java Dependencies WIP: Update Dependencies Aug 22, 2024
@jfaltermeier jfaltermeier force-pushed the jf/update-deps branch 3 times, most recently from a8e2342 to a9d4a95 Compare August 22, 2024 11:07
* update axios and express
* fix testing-page

Contributed on behalf of STMicroelectronics
@jfaltermeier jfaltermeier changed the title WIP: Update Dependencies Update Dependencies Aug 22, 2024
@jfaltermeier jfaltermeier marked this pull request as ready for review August 22, 2024 12:37
Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM 🥳 The testing page - using the common module - still worked well. Both monitor extensions also still work: They returned timestamps and showed the notification popup

@jfaltermeier jfaltermeier merged commit 39be9e4 into main Aug 23, 2024
21 checks passed
@jfaltermeier jfaltermeier deleted the jf/update-deps branch August 23, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants