Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Bump fix-path to ^4.0.0 to avoid cross-env <6.0.6 #14781

Conversation

Torbjorn-Svensson
Copy link
Contributor

cross-env 6.0.6 fixes CVE-2024-21538
(https://security.snyk.io/vuln/SNYK-JS-CROSSSPAWN-8303230).

What it does

Bumps fix-path dependency to 4.0.0 to avoid indirect dependency on vulnerable cross-env@<6.0.6.

How to test

I have just bumped the dependency and verified that the electron build starts using details described in the quickstart guide

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

Contributed by STMicroelectronics

cross-env 6.0.6 fixes CVE-2024-21538
(https://security.snyk.io/vuln/SNYK-JS-CROSSSPAWN-8303230).

Contributed by STMicroelectronics

Signed-off-by: Torbjörn SVENSSON <[email protected]>
Copy link
Contributor

@rschnekenbu rschnekenbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for your contribution, @Torbjorn-Svensson

@rschnekenbu rschnekenbu merged commit d59071a into eclipse-theia:master Jan 29, 2025
11 checks passed
@github-actions github-actions bot added this to the 1.58.0 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants