Notebook: fixed small race condition for outputs #14789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is instanciated Signed-off-by: Jonah Iden <[email protected]>
msujew
approved these changes
Jan 29, 2025
packages/plugin-ext/src/main/browser/notebooks/renderers/cell-output-webview.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Mark Sujew <[email protected]> Signed-off-by: Jonah Iden <[email protected]>
jonah-iden
force-pushed
the
jiden/cell-output-disapearing
branch
from
7df1cf7 to
841139c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This fixes a small race condition that could happen when the rendering of the outputs widget was triggered before the
WebviewWidget. This led to the outputs not being rendered at allHow to test
The only way i was able to reproduce this once was when i had an notebook with outputs open and then did a window reload.
Follow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers