-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix translation update script #14794
Conversation
Triggered a test run here: https://github.com/eclipse-theia/theia/actions/runs/13048824155/job/36404384953#step:7:146 |
Alternatively, we could add a "translate" script to the root package.json. |
Getting "Too many requests" again (https://github.com/eclipse-theia/theia/actions/runs/13048824155). I don’t think there’s anything I can do about it. Deepl status looks fine: https://www.deeplstatus.com/ |
@jfaltermeier My API token almost hasn't been used this month. It seems like we're hitting some rate limiting? I'll take a look at it. |
@jfaltermeier I pushed a commit to this PR that should resolve the issue. It seems like DeepL has implemented rather strict rate limiting (without saying what it is - the documentation just says to "try again after a delay"). |
Thanks, with these commits I get: https://github.com/eclipse-theia/theia/actions/runs/13050402257/job/36409193760#step:7:151
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks reasonable to me. Does it work with the deepl API, though?
What it does
Fixes this error: https://github.com/eclipse-theia/theia/actions/runs/13048443071/job/36403212934#step:7:20
How to test
Follow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers