Fix recent workspace tracking for devcontainer workspaces #14925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure devcontainer workspaces are correctly added to recentWorkspaces. Previously, incorrect URI handling caused invalid workspace entries. Now, the workspace path is passed instead of the full URI. Also the setMostRecentlyUsedWorkspace is now called with the correct workspace. Renamed the ContainerConnectionOptions.workspaceUri to workspacePath for consistency. Signed-off-by: Simon Graband <[email protected]>
jonah-iden
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
Didn't even know this was broken. Thanks alot for the fix. Seems to work fine.
There is only still the issue for me that opening a recent workspace creates a new container instead of reusing the existing one. I thought this was working once but i think that has nothing to do with these changes
|
Thank you for the fast review! Do we have a ticket for the issue you have metioned? |
|
i don't think so |
|
Can you reproduce this everytime? For me this sometimes works and sometimes does not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Ensure devcontainer workspaces are correctly added to recentWorkspaces.
Previously, incorrect URI handling caused invalid workspace entries.
Now, the workspace path is passed instead of the full URI.
Also the setMostRecentlyUsedWorkspace is now called with the correct workspace.
Renamed the ContainerConnectionOptions.workspaceUri to workspacePath for consistency.
How to test
(Same steps for reproducing the issue on current master, except there the entry is not moved to the top and another weird entry is added)
Follow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers