Planger/fix-terminal-assistant-styling #14949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The terminal assistant styling was broken, especially in light theme. This PR fixes the styling.
JonasHelming
approved these changes
Feb 17, 2025
|
Thanks for the review! Yeah, it is hard to find a combination of colors that will perfectly match all themes. I guess this is good enough for now, we can always revisit to optimize specific themes. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The terminal assistant styling was broken, especially in light theme. This PR fixes the styling.
How to test
Open a terminal and open the AI assistant (Ctrl-I or context menu).
Check a few themes to make sure it looks fine on the most important ones.
Follow-ups
None
Breaking changes
Attribution
None
Review checklist
Reminder for reviewers