Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make context element mandatory when showing a context menu. #14982

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

tsmaeder
Copy link
Contributor

What it does

This PR makes the context menu argument when showing a context menu mandatory. This is necessary to attach the context menu to the correct window when extracting widgets to secondary window. If now context element is available at a call site, clients can just pass window.document.body as the context.

Fixes #14960

How to test

Check that context menus everywhere are shown in the correct location and have the correct content for the location of the menu. This also includes "more" menus on toolbars, etc. (i.e. all menus other than the main menu bar. Where available, check that the menus work in secondary windows.

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Contributed on behalf of STMicroelectronics

Review checklist

Reminder for reviewers

Fixes eclipse-theia#14960

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder tsmaeder mentioned this pull request Feb 25, 2025
6 tasks
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me! thanks!

@tsmaeder tsmaeder merged commit 73ff47b into eclipse-theia:master Feb 25, 2025
10 of 11 checks passed
@github-actions github-actions bot added this to the 1.59.0 milestone Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Terminal Context Menu on wrong Window
3 participants