Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only send visiblity change notification when the visibility actually changes #15040

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

tsmaeder
Copy link
Contributor

What it does

Title says it all

Fixes #15038

How to test

Make sure switching between editors and extracting editors work both in browser and electron versions of Theia

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Contributed by STMicroelectronics

Review checklist

Reminder for reviewers

…changes

Fixes eclipse-theia#15038

Contributed by STMicroelectronics

Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder tsmaeder requested a review from sdirix February 25, 2025 13:04
@tsmaeder tsmaeder mentioned this pull request Feb 25, 2025
6 tasks
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me in Browser and Electron on Ubuntu 22.04. Thanks!

Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder tsmaeder merged commit 3dde0ac into eclipse-theia:master Feb 25, 2025
10 of 11 checks passed
@github-actions github-actions bot added this to the 1.59.0 milestone Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Editors are no longer extractable
2 participants