Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15035: Missing I18N in UI #15083

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CamilleLetavernier
Copy link
Contributor

What it does

  • Localize some commands and texts that were missing

Note: the original issue contains a long list of commands that were previously not localized. Localizations are generated quite late in the release cycle, so they have been introduced just yesterday morning. Only a few localize calls were actually missing from the code base; so I added them.

How to test

The PR only introduces nls.localize() calls, so it can't immediately be tested. I'm not sure what is the best way to test the changes, but what I did:

  • Add (a subset of) the keys to your favorite language, in packages/core/i18n/nls.**.json

For example, in French:

"theia": {
    "core": {
      "about": {
          "listOfExtensions": "Liste des extensions"
      }
    }
}
  • Start Theia
  • In the Command Palette, call Configure Display Language and select the modified language
  • Restart Theia Frontend
  • Check that the localized messages properly appear (For this example: open the "About" dialog)

Follow-ups

  • Wait until all keys are officially localized (Typically done just before release)

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs merge
Development

Successfully merging this pull request may close these issues.

2 participants