Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15048: delete the change set when all changes are deleted #15084

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CamilleLetavernier
Copy link
Contributor

fixes #15048

What it does

  • Delete the entire ChangeSet from the Chat when the last change is deleted

How to test

  • Ask Coder to provide changes (on one or several files), for example:

Can you suggest 3 arbitrary changes to improve the code in #currentRelativeDirPath ? This is just a test, so be creative. Changes should affect multiple files

  • Delete all changes one by one
  • Once the last change is deleted, the change set should disappear as well (instead of remaining empty)

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behavior seems reasonable to me. Possibly we should also make allowances in the UI for empty change sets, though, rather than relying on their deletion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs merge
Development

Successfully merging this pull request may close these issues.

[Theia AI] Coder ChangeSet minor issue - Delete the change set when all changes are deleted
2 participants