Improve displaying inline frame decorator #15097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* the logic to display the inline frame decorator should be independent of local state * Now, the inline frame decorator is shown, when the column points behind the beginning of a line (excluding whitespace) Signed-off-by: Florian Richter <[email protected]>
msujew
approved these changes
Mar 3, 2025
msujew
added
debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Improve logic when to show inline frame decorator.
Currently, the displaying inline frame decorator depends on local state, that is where the frame decorator previously pointed to. However, this has inconsistent results, when reaching a line from different locations.
Now, the inline frame decorator always is shown, when the column points behind the beginning of a line (excluding white space). I think, this best reflects the objective to show the inline decoration only when it's needed.
Fixes #15095
How to test
Test with any program, which contains lines with multiple statements.
Note: The python debug adapter seems to always set the column to 1, so this cannot be reproduced in python.
However, the javascript debug adapter provides column information.
See #15095 how to reproduce the bug.
Breaking changes
Attribution
Contributed by MVTec Software GmbH
Review checklist
Reminder for reviewers